Skip to content

Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) #20665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2025
Merged

Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) #20665

merged 4 commits into from
Jul 8, 2025

Conversation

vitalif
Copy link
Collaborator

@vitalif vitalif commented Jul 4, 2025 •
edited
Loading

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Fixes a schemeshard crash in the following case:

  1. replace a vector index (ydb -e grpc://host:2135 -d /Root/testdb table index rename --replace --index-name idx_vector2 --to idx_vector test_table)
  2. then do one of the following:
    2.1. drop the table
    2.2. drop the index
    2.3. replace the index with another vector index again

@vitalif vitalif requested a review from a team as a code owner July 4, 2025 17:52
@vitalif vitalif linked an issue Jul 4, 2025 that may be closed by this pull request
Something with vector indexes leads to YDB docker crash #20501
Closed
@vitalif vitalif requested a review from kunga July 4, 2025 17:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

⚪ 2025-07-04 17:54:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 972e172 has started.
⚪ 2025-07-04 17:55:08 UTC Artifacts will be uploaded here
⚪ 2025-07-04 17:59:13 UTC ya make is running...
🟡 2025-07-04 19:04:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29668 28257 0 1 1366 44

⚪ 2025-07-04 19:06:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-04 19:17:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
348 (only retried tests) 301 0 0 9 38

🟢 2025-07-04 19:17:40 UTC Build successful.
🟢 2025-07-04 19:17:59 UTC ydbd size 2.2 GiB changed* by +368 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 972e172 diff diff %
ydbd size 2 387 865 384 Bytes 2 387 865 752 Bytes +368 Bytes +0.000%
ydbd stripped size 499 603 048 Bytes 499 603 240 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

🟢 2025-07-08 12:52:20 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

⚪ 2025-07-04 17:57:10 UTC Pre-commit check linux-x86_64-release-asan for 972e172 has started.
⚪ 2025-07-04 17:57:21 UTC Artifacts will be uploaded here
⚪ 2025-07-04 18:00:32 UTC ya make is running...
🟡 2025-07-04 19:42:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14281 13938 0 119 195 29

🟢 2025-07-04 19:43:22 UTC Build successful.
🟢 2025-07-04 19:43:50 UTC ydbd size 3.9 GiB changed* by +576 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 972e172 diff diff %
ydbd size 4 200 002 176 Bytes 4 200 002 752 Bytes +576 Bytes +0.000%
ydbd stripped size 1 455 233 272 Bytes 1 455 233 656 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

azevaykin
azevaykin reviewed Jul 5, 2025
View reviewed changes
@vitalif vitalif requested a review from CyberROFL July 7, 2025 10:01
@kunga kunga removed their request for review July 7, 2025 10:02
azevaykin
azevaykin reviewed Jul 8, 2025
View reviewed changes
azevaykin
azevaykin reviewed Jul 8, 2025
View reviewed changes
@vitalif vitalif force-pushed the fix-vector-index-replace-alive-children-count branch from e2ab35f to 3252184 Compare July 8, 2025 11:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025 •
edited
Loading

⚪ 2025-07-08 11:14:49 UTC Pre-commit check linux-x86_64-release-asan for 91bb8c1 has started.
⚪ 2025-07-08 11:15:01 UTC Artifacts will be uploaded here
⚪ 2025-07-08 11:18:14 UTC ya make is running...
🟡 2025-07-08 12:57:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14322 13979 0 96 218 29

🟢 2025-07-08 12:58:25 UTC Build successful.
🟢 2025-07-08 12:58:53 UTC ydbd size 3.9 GiB changed* by +89.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7c81ab1 merge: 91bb8c1 diff diff %
ydbd size 4 199 917 448 Bytes 4 200 008 544 Bytes +89.0 KiB +0.002%
ydbd stripped size 1 455 301 560 Bytes 1 455 332 728 Bytes +30.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025 •
edited
Loading

⚪ 2025-07-08 11:15:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 91bb8c1 has started.
⚪ 2025-07-08 11:16:08 UTC Artifacts will be uploaded here
⚪ 2025-07-08 11:19:28 UTC ya make is running...
🟡 2025-07-08 12:25:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29727 28309 0 5 1363 50

⚪ 2025-07-08 12:28:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-08 12:39:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
263 (only retried tests) 223 0 0 3 37

🟢 2025-07-08 12:39:30 UTC Build successful.
🟢 2025-07-08 12:39:50 UTC ydbd size 2.2 GiB changed* by +272 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9adb3a0 merge: 91bb8c1 diff diff %
ydbd size 2 388 360 008 Bytes 2 388 360 280 Bytes +272 Bytes +0.000%
ydbd stripped size 499 817 288 Bytes 499 817 352 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitalif vitalif requested a review from azevaykin July 8, 2025 11:25
@vitalif vitalif mentioned this pull request Jul 8, 2025
Merged
@vitalif vitalif enabled auto-merge (squash) July 8, 2025 12:24
@azevaykin azevaykin changed the title Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) 25-1-2: Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) Jul 8, 2025
@vitalif vitalif changed the title 25-1-2: Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) Fix schemeshard crashes on double vector index replace / drop table after index replace (#20501) Jul 8, 2025
@vitalif vitalif merged commit d332eed into ydb-platform:main Jul 8, 2025
19 checks passed
@vitalif vitalif mentioned this pull request Jul 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@azevaykin azevaykin azevaykin approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something with vector indexes leads to YDB docker crash
3 participants
@vitalif @CyberROFL @azevaykin